Arrow Keydown event triggers click event for all [role="menu]

[chamelea]

I am writing my own aria menu object and handling the document click event differently than the document arrow keydown event. I was surprised when dropdown.js actually triggered a click event when I used the down arrow.

See:
https://github.com/twbs/bootstrap/blob/master/js/dropdown.js#L158
https://github.com/twbs/bootstrap/blob/master/js/dropdown.js#L72

[patrickhlauke]

It fires click in an attempt to keep the code DRY, as opening the menu hangs off the click event [edit: or rather, it hangs off the toggle, which is triggered from click]. So I'd say it's by design. If you're writing a custom object, you may have to override the behavior yourself (which I'm guessing you'd have to do anyway, if implementing your own handler?)

[chamelea]

Yeah - that's exactly how I'm working around it. I wanted to call it out in case there was a way to better scope to just bootstrap dropdowns. Thanks for the fast reply!

[patrickhlauke]

oh, now i see what you mean (re scoping to just bootstrap). that's actually an interesting idea (though it would probably require a lot of extra work to do that same kind of scoping explicitly for all components). @fat ?

[cvrebert]

The [role="menu"] event handler was added way back in 9889948#diff-8a0a7067ead1e0530699852517369ddaR149 without much explanation.
Perhaps we could just use .dropdown-menu as the selector instead?

[patrickhlauke]

i think that would make sense (also in light of parallel discussions in #16179 about possibly removing some of the role="menu" instances to avoid authors tripping AT up unknowingly when they go beyond the normal menu pattern)