Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

active and hovered checkbox button background colors should not be the same #17101

Closed
philgyford opened this issue Aug 20, 2015 · 5 comments
Closed

active and hovered checkbox button background colors should not be the same #17101

philgyford opened this issue Aug 20, 2015 · 5 comments
Labels
confirmed css v4
Milestone
v4.0.0-alpha.2

Comments

@philgyford
Copy link

If a v4 checkbox button is 'active' then clicking it with the cursor to uncheck it provides no visual feedback. This is because the 'active' and 'hover' states have the same background colours. You have to move the cursor away from the button to verify it is now unchecked.

Here, the middle checkbox is not checked/active, although it looks like it is:

checkboxes
@philgyford philgyford changed the title Un-checking checkbox buttons provides no visual feedback v4: Un-checking checkbox buttons provides no visual feedback Aug 20, 2015
@cvrebert cvrebert changed the title v4: Un-checking checkbox buttons provides no visual feedback active and hovered checkbox button background colors should not be the same Aug 20, 2015
@patrickhlauke
Copy link
Member

hmmm...i'm fairly sure i had a PR in v3 that addressed this exact problem. wonder if it got left out in the transition to v4...

ah, i'm thinking of this #16154

@cvrebert
Copy link
Collaborator

*sigh* And this is why I said we should audit the recent v3 commits to ensure they had been ported and thus guard against such regressions...

@cvrebert cvrebert added this to the v4.0.0-alpha.2 milestone Aug 20, 2015
@mdo
Copy link
Member

mdo commented Aug 23, 2015

sigh

There were bond to be oversights on my part :).

mdo added a commit that referenced this issue Aug 23, 2015
@mdo
re-fix #16154 in v4-dev /cc #17101
1f153b6
@mdo
Copy link
Member

mdo commented Aug 23, 2015

Addressed in 1f153b6.

@mdo mdo closed this as completed Aug 23, 2015
@patrickhlauke
Copy link
Member

<3

azmenak pushed a commit to azmenak/bootstrap that referenced this issue Aug 27, 2015
@mdo @azmenak
re-fix twbs#16154 in v4-dev /cc twbs#17101
34b42cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed css v4
Projects
None yet
Milestone
v4.0.0-alpha.2
Development

No branches or pull requests
4 participants
@philgyford @mdo @cvrebert @patrickhlauke