Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline checkbox and radio text vertically misaligned on Firefox #18239

Closed
hackel opened this issue Nov 13, 2015 · 5 comments
Closed

Inline checkbox and radio text vertically misaligned on Firefox #18239

hackel opened this issue Nov 13, 2015 · 5 comments
Labels

Comments

@hackel
Copy link

hackel commented Nov 13, 2015

As seen in the first image below from your own documentation (http://getbootstrap.com/css/#inline-checkboxes-and-radios), checkboxes and radios are not properly aligned with their labels. I believe this is due to the 4px top margin applied here: https://github.com/twbs/bootstrap/blob/master/less/forms.less#L54 In the second image, I disabled this margin, and they are aligned properly.
bootstrap-checkbox-alignment

I'm running Firefox 44, but have seen this issue on previous Firefox versions for quite some time.

Edit: Also, when toggling that margin off in Chrome, the checkboxes get misaligned in the opposite way.

@cvrebert cvrebert changed the title Inline checkboxe and radio alignment issue on Firefox Inline checkbox and radio alignment issue on Firefox Nov 13, 2015
@cvrebert
Copy link
Collaborator

@hackel Could you please re-test against the latest code in the master branch?

@cvrebert cvrebert changed the title Inline checkbox and radio alignment issue on Firefox Inline checkbox and radio text vertically misaligned on Firefox Nov 13, 2015
@hackel
Copy link
Author

hackel commented Nov 18, 2015

I am still seeing it on master.

@cvrebert
Copy link
Collaborator

cvrebert commented Dec 1, 2015

As of Bootstrap v3.3.6 and Firefox 44.0a2 on OS X, the labels seem to be aligned reasonably well:
checkbox

I'm happy to reopen this if you can point out a case where the alignment is still bad.

@cvrebert cvrebert closed this as completed Dec 1, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Dec 1, 2015

X-Ref: #15791, #13936

@hackel
Copy link
Author

hackel commented Dec 11, 2015

Ah, okay, I am seeing #15791. I don't use any proprietary operating systems so I can't say how it performs on them, but it's definitely still present in v3.3.6 on GNU/Linux/Xorg-based operating systems. Not seeing it on Firefox 43 on Android/Linux at least!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants