Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of labels and checkboxes/radios bad in Firefox on KDE GNU/Linux #15791

Closed
wolftune opened this issue Feb 11, 2015 · 17 comments
Closed

Comments

@wolftune
Copy link

From right on the Bootstrap website itself. Looks ok in Chromium but lousy in Firefox:

bad-radio-checkbox-positions

That's just a screen-shot from http://getbootstrap.com/css/ visited in Firefox 35.0.1 on Ubuntu. Most noticeably, the vertical-alignment is off, but it also seems to lack some space between the buttons and the labels.

@kkirsche
Copy link
Contributor

I think this has more to do with the operating system then the theme. It's due to the larger size of the default buttons. Firefox 35.0.1 on Mac looks fine in that same part:

screen shot 2015-02-11 at 9 02 16 am

Unless they override OS button styles, I'm not sure this is worth chasing.

@wolftune
Copy link
Author

This is not strictly an OS issue because, as stated, the same thing looks fine on Chromium on the same OS. However, it's obvious that it related to the OS.

@patrickhlauke
Copy link
Member

It is OS-specific, as I suspect Firefox on Linux uses the OS-native form controls ([EDIT] it seems it also does this still on Windows and Mac), while Chromium does its completely custom controls.

Here's FX on Win, for comparison:

firefox-win

@wolftune wolftune changed the title Position of labels and checkboxes/radios bad in Firefox Position of labels and checkboxes/radios bad in Firefox on KDE GNU/Linux Feb 11, 2015
@patrickhlauke
Copy link
Member

In principle though, I agree it would be useful to ensure that even on Linux, the control + label combo is at least vertically centered somehow...

@wolftune
Copy link
Author

I don't know if this is helpful or what else to do, but it looks good on my system if I make the buttons position: relative instead of absolute and use vertical-align: sub. But that's a hacky solution it seems. The position changes does make Chromium slightly worse. Anyway, it needs both of those together to be effect even as a hack.

@kkirsche
Copy link
Contributor

Firefox on Ubuntu 14.04 Unity

screen shot 2015-02-11 at 11 22 21 am
screen shot 2015-02-11 at 11 26 07 am

Will pull up my copy of KDE next.

@kkirsche
Copy link
Contributor

Yep, I can duplicate it only with Kubuntu 14.10 Plasma 4

screen shot 2015-02-11 at 11 42 58 am

I personally would recommend filing the bug with KDE or Firefox as this seems more related to them than Bootstrap I feel at least.

@wolftune
Copy link
Author

Even on that Unity screen-shot the vertical align is a little off…

@wolftune
Copy link
Author

I found https://bugzilla.mozilla.org/show_bug.cgi?id=210212

But that's 12 years old, and I can't tell if it's really related. Maybe a new ticket makes sense, I'm unsure.

@wolftune
Copy link
Author

Note that on a plain site with no Bootstrap at all, the look isn't super, but it's not so bad.

I used

<form method="get">
<input type="radio" value="Red" name="preferred_color"> Red<br>
<input type="radio" value="Blue" name="preferred_color"> Blue<br>
<input type="radio" value="Green" name="preferred_color"> Green<br>
<input type="submit" value="Submit">
</form>

And got
simpleradios

So, it's not like Firefox in KDE is just doing this stuff badly always.

@kkirsche
Copy link
Contributor

Same result as you just posted @wolftune after normalize.css is applied. Just working through identifying if this is in Bootstrap itself and making sure it's not in an upstream item they are using

@K4T
Copy link

K4T commented Mar 4, 2015

Same problem here on those browsers:
Desktop: Firefox 35, 36
Mobile: Iphone 5 newest Safari browser, native Android 4.3 browser.

Funny thing: that problem doesn`t occur on Firefox mobile.

Are you really sure that is browser bug? Any chances to get it work?

@kkirsche
Copy link
Contributor

kkirsche commented Mar 4, 2015

@K4T — what operating system for the Desktop browsers? Are you confirming simply for KDE based Linux systems on those versions or other operating system(s)? If other operating systems, could you please state those so they can be confirmed?

On my iPhone 5S yes it's a tiny bit higher, but not nearly like in the examples shown in my opinion. Thanks for sharing your take on it though. 😃

@K4T
Copy link

K4T commented Mar 4, 2015

@kkirsche I tested it on Windows 8.1.

Btw: on native Android 4.3 browser it`s much more higher than on iPhone.

@patrickhlauke
Copy link
Member

Confirming that there is a very slight vertical misalignment here in iOS/Safari and Win8.1/Firefox [edit: and IE11] - so it may indeed need a slight tweak somewhere... /cc @mdo

ios-safari
iOS/Safari

bootstrap-radio-check-firefox
Win8.1/Firefox

ie11
Win8.1/IE11

@mdo
Copy link
Member

mdo commented Mar 28, 2015

There's no easy way to accomplish 100% cross browser consistency here. Some of the Linux browsers are bound to cause problems like this. Punting as a won't fix.

@mdo mdo closed this as completed Mar 28, 2015
@wolftune
Copy link
Author

We don't need 100% cross-browser consistency, we just need it not to be really off, as it is in KDE Firefox… The rest of the examples are just subtle and can be ignored, but please don't just lump everything together. There's a specific case that is really off and should be fixed…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants