Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong vertical alignment for input-group with radio or checkbox #20271

Closed
praveenpuglia opened this issue Jul 11, 2016 · 5 comments
Closed

Wrong vertical alignment for input-group with radio or checkbox #20271

praveenpuglia opened this issue Jul 11, 2016 · 5 comments
Labels

Comments

@praveenpuglia
Copy link
Contributor

Here, in this docs section, the radio and the checkbox, used as addon to input do not vertically align center as expected. They are a little bit above the horizontal center line.

Here's the screenshot.
image

Adding a vertical-align: middle property to the following rule in _input-group.scss fixes the problem though.

.input-group-addon input[type=checkbox], 
.input-group-addon input[type=radio] {
  vertical-align: middle;
}

Here's the output screenshot.
image

Should I send a PR for it? or the issue's source is something else?

@cvrebert
Copy link
Collaborator

Unless you want to do the manual cross-browser testing for the PR yourself, this will likely end up WontFix per #18797.

@praveenpuglia
Copy link
Contributor Author

Will testing on latest of Chrome, Safari, Firefox & Edge do the job?

@cvrebert
Copy link
Collaborator

Also Android, iOS, and IE11. If you can cover most of them, we might be able to help with the last few.

@friscoMad
Copy link

Have you considered asking for a free license of Browserstack?
They have free licenses for Open Source projects and I am sure they will be willing to add Bootstrap to their client list, check https://www.browserstack.com/pricing

@mdo
Copy link
Member

mdo commented Oct 10, 2016

I think these are as well aligned as they can be across browsers. Happy to see someone revisit if they're running into egregious problems, but otherwise this is going to stay as-is in v4's development.

@mdo mdo closed this as completed Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants