Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox/radio aligned too low #18797

Closed
quasipickle opened this issue Jan 7, 2016 · 8 comments
Closed

Checkbox/radio aligned too low #18797

quasipickle opened this issue Jan 7, 2016 · 8 comments
Labels

Comments

@quasipickle
Copy link
Contributor

The default checkbox/radio alignment seems to be with the bottom of it's associated label text. To me, visually this makes the elements seem too low. The inline variants appear to have the boxes aligned with the middle of the text, which looks better.

@mdo
Copy link
Member

mdo commented Jan 7, 2016

What version of Bootstrap? What browser (version and OS)? Screenshots?

@quasipickle
Copy link
Contributor Author

Duh - right, sorry.

The v4 Alpha. You can actually see this in the documentation on both Chrome and Firefox on OS X.

checkboxes

@cvrebert cvrebert added the v4 label Jan 7, 2016
@quasipickle
Copy link
Contributor Author

In practice the boxes seem to be aligned to the top:

practice

so it looks to be a documentation/browser bug stemming from _forms.scss:193

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 7, 2016

X-Ref: #13936, #15791

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 7, 2016

Some findings:

  • OS X Chrome checkbox dimensions: 28x28 (native px)
  • OS X Chrome radio button dimensions: 32x32 (native px)

Currently, in bleeding-edge v4, the strikethrough line of the label text is 1 native px below the center of the checkbox/radio:
chrome

(Strikethrough being one possible interpretation of the "vertical center" of text)

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 7, 2016

For Firefox:

  • OS X Firefox checkbox dimensions: 24x24 (native px)
  • OS X Firefox radio button dimensions: 28x28 (native px)

Similarly, the strikethrough line of the label text is currently 1 native px below the center of the checkbox/radio, though Firefox's strikethrough is lower than Chrome's (in a bad way):
firefox

(Guess I should find a different metric..)

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 8, 2016

For Safari:

  • Safari radio button dimensions: 16x17 (native px)
  • Safari checkbox dimensions: 14x15 (native px)

safari

And since my screen is retina (and after double-checking manually), CSS px equal 2 of my native px.

@mdo
Copy link
Member

mdo commented Feb 7, 2016

Always bummed to find these problems, hah. Seeing it in Firefox, but not in Chrome. Going to close this as a won't fix since it's virtually impossible to get this 100% locked down across browsers. If y'all have any specific ideas for what we could try, I'm all for it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants