Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom-file selector isn't a valid CSS value since upgrade to beta3 #25127

Closed
javinto opened this issue Dec 29, 2017 · 2 comments
Closed

custom-file selector isn't a valid CSS value since upgrade to beta3 #25127

javinto opened this issue Dec 29, 2017 · 2 comments

Comments

@javinto
Copy link

javinto commented Dec 29, 2017

I have a Ruby-on-rails project (using the Bootstrap gem) where I use the custom file selector text according to the documentation:

$custom-file-text: (
  placeholder: (
    en: "Choose file...",
    nl: "Selecteer bestand..."
  ),
  button-label: (
    en: "Browse",
    nl: "Selecteer"
  )
);

After upgrading from beta 2.1 to beta 3 I now get the following error:

(en: "Choose file...", nl: "Selecteer bestand...") isn't a valid CSS value.

As I'm using SASS I ensured not upgrading any other gem but Bootstrap to exclude other gems from being the problem gem.

I could not find any upgrade or migration information on this specific component. So I suspect it is a bug. Here is my error:

schermafbeelding 2017-12-29 om 23 32 08

@mdo
Copy link
Member

mdo commented Dec 30, 2017

We need to update the Migration docs—that Sass map has changed. See our _variables.scss file.

afomera added a commit to ProctorU/hootstrap that referenced this issue Dec 30, 2017
The SCSS map for $custom-file-text has changed. Per this GH issue:
twbs/bootstrap#25127

I looked at the _variables.scss file to find the updated map.
@javinto
Copy link
Author

javinto commented Dec 30, 2017 via email

@mdo mdo added the has-pr label Dec 30, 2017
mdo added a commit that referenced this issue Dec 30, 2017
licatajustin pushed a commit to ProctorU/hootstrap that referenced this issue Jan 5, 2018
The SCSS map for $custom-file-text has changed. Per this GH issue:
twbs/bootstrap#25127

I looked at the _variables.scss file to find the updated map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants