Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded colors outside variables.less #3762

Closed
ciembor opened this issue Jun 7, 2012 · 2 comments
Closed

Hardcoded colors outside variables.less #3762

ciembor opened this issue Jun 7, 2012 · 2 comments
Labels

Comments

@ciembor
Copy link

ciembor commented Jun 7, 2012

I think all colors should be relative to these defined in variables.less file. It would simplify customization. For the time being there are few colors hardcoded in other files. Here is list of these colors:

gray:

pink:

  • #b94a48
  • #d14
  • #ee575b

I can fix this, but I have a question. Should I declare new variables in variables.less (with names corresponding to their destiny) or should I use already declared variables and LESS color functions? The first method is more proper because someone who wants dark background will probably swap @grayLighter with @grayDarker.

@ciembor
Copy link
Author

ciembor commented Jun 8, 2012

I would be glad if you could write what do you think about that. I really want to do something with this, because I'm working on a Bootstrap customization tool and it may save my life.

@mdo
Copy link
Member

mdo commented Jun 25, 2012

This has come up before, and the answer remains that we'll fix these as we go along. If you want, submit a pull request against the latest working branch in small batches and we'll make it happen sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants