-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0-wip: consider adding a bootstrap class for table #999
Comments
+1 I also experienced the giant tables in datepickers when using bootstrap. |
+1 |
Done, |
I just got to delete a ton of CSS. Thanks! |
ghost
mentioned this issue
Feb 2, 2012
Closed
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this issue
Nov 4, 2014
`@gray-light` darkens from twbs#999 to twbs#777, which puts `.text-muted` at the threshold for the 4.5:1 WCAG minimum contrast[1]. twbs#777:#fff is 4.48:1. The “Example” headers in docs become #959595, which is contrast ratio 3:1, the minimum for larger text. Since the headers are less important than the surrounding text, 3:1 is fine and an improvement on the previous #bbb:#fff (1.92:1). Fixes issue twbs#13847. [1] http://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm not sure if you will reject this or not, but I'd like to propose it now, before 2.0 goes out and it is too late.
As much as I like the base table design for bootstrap, when integrating bootstrap with other code, such as the jquery datepicker (which makes heavy use of tables for its layout), I'm left doing a bunch of work to override the defaults that bootstrap sets up. If bootstrap changes in the future, I'm having to update my code to work around those changes again.
By simply name spacing bootstrap tables, this becomes a non-issue. I already have to add a class for a border-table or condensed-table, adding one more, say: pretty-table wouldn't be that big of a stretch.
I know that you can argue that this can happen anywhere bootstrap defines the look and feel of an element, but this is one of those places where tables are used both for design, but also for layout. I know everyone is supposed to use div's these days for layout, but the reality is that not everything does and having to work around bootstrap is somewhat of a pain in this sense.
I realize this has been discussed before in other contexts (#80), but I'd like to bring it up again.
Thanks for listening.
The text was updated successfully, but these errors were encountered: