-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown menus don't get closed when selecting an option #4497
Comments
I have the same problem. Dropdowns used to close automatically when selecting an option, after upgrade to 2.1.0 they do not close anymore when an option is selected. |
I have several dropdown into a navbar and it's always the first initialized who works well. Others do not want to close when I choose (click) an option OR if I click somewhere else on the page to close it. The problem is here since the 2.1 version. |
Hi, Same problem for me : |
I've commented on the line of code that caused this here: c9cef74#js/bootstrap-dropdown.js. Change the target for the event to ".dropdown form" and it should be fixed. |
@zachlowry This fixes the issue for me, thanks |
Removing "form" from the selector also prevents menu items using rails jquery_ujs from working (e.g. :method => :delete for a sign out link). |
+1 on this issue |
+1 on this issue |
Here's an interim solution until the 2.1.1 comes through:
Edit: I should add, in case it's not clear, that this workaround is really only intended for those loading Bootstrap off a CDN. If you're hosting your own code, just fix it directly. :P |
Thanks for the workaround! |
+1 on this... |
+1 for me too. Glad I'm not the only one that was confused. |
added the form bit back, which fixes this – will look into another way of handling the mobile stuff |
@fat - I'm not seeing the commit in the Github commits that fixes this. Am I missing something? |
@mhuggins It's on the wip branch: https://github.com/twitter/bootstrap/blob/2.1.1-wip/js/bootstrap-dropdown.js |
Ahh, didn't realize that's how Twitter does it. Thanks! |
A temporary workaround can be found here for incompatibilty with jquery-rails while waiting 2.1.1 release : seyhunak/twitter-bootstrap-rails#343 |
the same issue |
$('.dropdown-menu select, .dropdown-menu textearea').click(function(e) { |
Another possible solution - twbs/bootstrap#4497 For #549
perfect marcelometal!!! |
[Tested on Chrome 21, Safari 6 and Firefox 14]
I've upgraded Bootstrap on a test-branch and dropdown menus no longer close automatically once an option is selected. User has to click outside for the menu to disappear.
The problem is reproducible in the official docs: http://twitter.github.com/bootstrap/javascript.html#dropdowns
Did I miss something on the changelog about this new behaviour? If this is a "WON'T FIX", is there any workaround to force them to close?
The text was updated successfully, but these errors were encountered: