Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to view the docs with the v2 theme applied #9764

Closed
cvrebert opened this issue Aug 18, 2013 · 8 comments · Fixed by #13463
Closed

Add ability to view the docs with the v2 theme applied #9764

cvrebert opened this issue Aug 18, 2013 · 8 comments · Fixed by #13463

Comments

@cvrebert
Copy link
Collaborator

Maybe have a toggle button in the navbar?

@mdo
Copy link
Member

mdo commented Aug 18, 2013

Hmm... perhaps. Might need some extra CSS though to prevent the theme from overriding our own docs components (namely the navbar at the top and our custom buttons). If we could scope it to a class or ID, that'd be fantastic.

@zlatanvasovic
Copy link
Contributor

What about just adding theme section and pointing what's back?

@mdo
Copy link
Member

mdo commented Aug 18, 2013

@zdroid That's accomplished with the theme example template.

@zlatanvasovic
Copy link
Contributor

KK. So, it's not needed to have that toggle? I just see gradient changes... so it doesn't worth to switch themes (it causes additional script(s) + more styles and docs).

@cvrebert
Copy link
Collaborator Author

IMO, it's a good way to emphasize that the theme exists and is a first-class part of the project. Also, hopefully pretty easy to implement.

@zlatanvasovic
Copy link
Contributor

Ok, try to make that. ;)

2013/8/18 Chris Rebert [email protected]

IMO, it's a good way to emphasize that the theme exists and is a
first-class part of the project. Also, hopefully pretty easy to implement.


Reply to this email directly or view it on GitHubhttps://github.com//issues/9764#issuecomment-22827668
.

Zlatan Vasović - ZDroid

@mdo mdo mentioned this issue Aug 19, 2013
22 tasks
@mdo
Copy link
Member

mdo commented Aug 19, 2013

Will track as part of 3.1 per #9397.

@mdo mdo closed this as completed Aug 19, 2013
@zlatanvasovic
Copy link
Contributor

Great.

2013/8/19 Mark Otto [email protected]

Will track as part of 3.1 per #9397#9397
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/9764#issuecomment-22849273
.

Zlatan Vasović - ZDroid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants