Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint doc-assets like the customizer in testing #11033

Closed
wants to merge 1 commit into from

Conversation

stuartpb
Copy link
Contributor

This should let Travis-CI catch bugs in pull requests to things like the customizer, like #10632 and #10633.

The new rule excludes minified scripts like Respond.js, which I imagine don't lint properly.

Excludes minified scripts like Respond.js
@stuartpb
Copy link
Contributor Author

And of course the docs-assets are full of linting errors (many coming from inlined minified scripts). So this needs further revision to pass the new tests.

@mdo
Copy link
Member

mdo commented Oct 11, 2013

For the time being I don't think we need to lint these things, especially since they aren't meant to be used by the community. Open to hearing more thoughts on why this makes more sense beyond the Customizer, something I've long wanted out of our main docs and repo.

@mdo mdo closed this Oct 11, 2013
@stuartpb
Copy link
Contributor Author

Well, they are used by, and contributed to by, the community just as any other component of the docs (I'm talking mostly about the Customizer here).

@stuartpb
Copy link
Contributor Author

Actually, it appears docs/assets is linted in the current test suite (as of 2fc2fe7?)

@cvrebert
Copy link
Collaborator

Overturned in #11739.

@stuartpb stuartpb deleted the patch-3 branch May 12, 2014 16:30
@mdo
Copy link
Member

mdo commented May 12, 2014

@stuartpb Yeah, the tooling fell into place and overall I'm really regretting it at this point. It makes for super small assets when we concatenate things, but having to kill the server and run grunt dist as we do today just to change some docs CSS is just awful.

I think I conflated the linting with the above though, so at some point I plan on undoing some of the docs asset management and instead just keep things as simple as possible. This overhead really fucks with productivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants