When opening the dropdown, focus() the toggle BEFORE triggering 'shown' event #11281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing 'shown.bs.dropdown'
|
ya im happy with flipping it |
|
@fat So, are you okay with merging this for 3.2? |
|
yep |
Closed
jboning
added a commit
to jboning/eve_tools
that referenced
this pull request
Feb 28, 2015
Saves the user a precious click! This required a bootstrap upgrade because of twbs/bootstrap#11281 There were a few places where .row was used without a .container and the upgrade made those look terrible, so I fixed them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as much a question as it is a pull request. Is there a reason for calling $this.focus() AFTER triggering the 'shown' event? I've come across this multiple times now where I bind to the 'shown' event and try to focus() into an text input when the dropdown is shown. For example, if the dropdown menu has a text input in it. I can get around it by setting a timeout, and that doesn't bother me too much, but if it's all the same to you, maybe we should just flip the order here?