Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: IE10 or lower incorrectly determines the scrollheight of the body. ... #11937

Merged
merged 2 commits into from
Mar 14, 2014

Conversation

joepjoosten
Copy link
Contributor

IE10 or lower incorrectly determines the scrollheight of the body. Use document.documentElement for IE. To make this browser agnostic, the maximum scrollheight of both body and documentElement is used.

…y. Use document.documentElement for IE. To make this browser agnostic, the maximum scrollheight of both body and documentElement is used.
@cvrebert
Copy link
Collaborator

This apparently fails our JS style guidelines; see the Travis build output.

…y. Use document.documentElement for IE. To make this browser agnostic, the maximum scrollheight of both body and documentElement is used.
@joepjoosten
Copy link
Contributor Author

Added space after comma, now it's correctly styled.

@cvrebert cvrebert modified the milestones: v3.2.0, v3.1.1 Feb 9, 2014
@fat
Copy link
Member

fat commented Mar 14, 2014

lgtm thanks

fat added a commit that referenced this pull request Mar 14, 2014
Fix: IE10 or lower incorrectly determines the scrollheight of the body. ...
@fat fat merged commit 905c781 into twbs:master Mar 14, 2014
@mdo mdo mentioned this pull request Mar 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants