Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize test files #12291

Closed
wants to merge 1 commit into from
Closed

Reorganize test files #12291

wants to merge 1 commit into from

Conversation

zlatanvasovic
Copy link
Contributor

This reorganizes test files a bit. Only problem with test files is the browserstack.json — it must be in root.

@cvrebert
Copy link
Collaborator

So, what's the reason for renaming the directory?

@zlatanvasovic
Copy link
Contributor Author

-infra doesn't have sense for sause_browsers.yml?

@cvrebert
Copy link
Collaborator

Could make sense to move that file to /js/tests/

@zlatanvasovic
Copy link
Contributor Author

Hm. Possible. But test is nicer (shorter) name. ;)

Delay this for next release so we can discuss further.

2014/1/19 Chris Rebert [email protected]

Could make sense to move that file to /js/tests/


Reply to this email directly or view it on GitHubhttps://github.com//pull/12291#issuecomment-32718241
.

Zlatan Vasović - ZDroid

@zlatanvasovic
Copy link
Contributor Author

@cvrebert Is this ok (not for 3.1.0):

/
- tests/ (test/ is also ok)
-- js/ (move all the js test files there, so we don't need to worry about ignoring in bower.json)
-- css/ (move lint files from less/ so no need for filling up less/)
-- infra/ (move s3 files)
-- sauce_browsers.yml (directly in tests/ root)

Thoughts?

@mdo
Copy link
Member

mdo commented Jan 23, 2014

I'm meh on reorganizing any of this in v3.x. Maybe renaming test-infra, but not down with any of the other changes until v4. I'll make a note of that in our tracking issue.

@mdo mdo closed this Jan 23, 2014
@zlatanvasovic
Copy link
Contributor Author

Thanks.

2014/1/23 Mark Otto [email protected]

Closed #12291 #12291.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12291
.

Zlatan Vasović - ZDroid

@zlatanvasovic zlatanvasovic deleted the to branch January 23, 2014 07:20
@mdo mdo mentioned this pull request Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants