scrollspy: correct event naming of scroll and `load' event
#12337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sauce + BrowserStack tests pass: https://travis-ci.org/twbs/bootstrap/builds/17430541 |
|
this lgtm 👍 |
Closed
|
Turns out this breaks scrollspy highlighting in the docs somehow. See #13659. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event name
scroll.bs.scroll-spy.data-apiis bad in two points.First: namespace
bs.scroll-spyis different tobs.scrollspy. Firstone is only used for this event, so I bet it is wrong.Second: the event
scrollhas nothing to do with the data-api, so I remove it.The better event name is:
scroll.bs.scrollspyAnd the registration of the
loadevent handler should have a namespace. So I change it toload.bs.scrollspy.data-api.