Fix #12375: stop using document.body.scrollTop

[zlatanvasovic]

Removes document.body.scrollTop as it's deprecated in the strict mode.

Fixes #12375.

/cc @fat

[cvrebert]

Have you tested that this doesn't break any of the non-Chrome browsers?

[zlatanvasovic]

It works nice in Chrome, Firefox and Opera, not tested in IE and Safari.

2014-01-25 Chris Rebert [email protected]

Have you tested that this doesn't break any of the non-Chrome browsers?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12377#issuecomment-33297794
.

Zlatan Vasović - ZDroid

[ghost]

nice

[zlatanvasovic]

Ref:
http://stackoverflow.com/questions/19635188/why-is-body-scrolltop-deprecated

2014-01-26 roymps [email protected]

nice

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12377#issuecomment-33313393
.

Zlatan Vasović - ZDroid

[cvrebert]

Can't merge unless this gets tested in IE & Safari.

[zlatanvasovic]

Green Travis build (including Sauce) isn't enough? ;P

Can you test this on Safari, I don't have OS X?

[cvrebert]

The Sauce build is a no-op unless the PR branch is in the twbs/bootstrap repo.

[zlatanvasovic]

OK.

Note: this variant should theoretically work everywhere because it uses .scrollTop element method, but not on body. It's on documentElement now, which is supported by modern browers.

[XhmikosR]

I will try this on IE.

[XhmikosR]

Seems to work fine in IE8-10; I see the /javascript/#tooltips-examples as usual.

The PR needs rebasing BTW.

[fat]

lgtm 👍

[cvrebert]

Seems to work on Safari too.