Document popover focus #12688
Merged
Document popover focus #12688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@mdo This PR has an unrelated "Update Glyphicons" commit in it. |
|
Derp, resolved. |
| @@ -1160,8 +1162,11 @@ <h3 class="popover-title">Popover left</h3> | |||
|
|
|||
| <h3>Live demo</h3> | |||
| <div class="bs-example" style="padding-bottom: 24px;"> | |||
| <a href="#" class="btn btn-lg btn-danger" data-toggle="popover" title="A Title" data-content="And here's some amazing content. It's very engaging. right?" role="button">Click to toggle popover</a> | |||
| <button type="button" class="btn btn-lg btn-danger bs-docs-popover" data-toggle="popover" title="Popover title" data-content="And here's some amazing content. It's very engaging. Right?">Click to toggle popover</a> | |||
There was a problem hiding this comment.
Actually, all the instances of this code have mismatched tags.
Conflicts: docs/assets/js/docs.min.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents #10140, but while adding I hit the bug in #11788 (
trigger: 'focus'doesn't work in Safari and apparently Firefox). When that bug gets fixed, we can merge this in.