Remove event aliases from JavaScript

[hnrch02]

Makes life for people with custom jQuery builds excluding event aliases much easier.

[cvrebert]

I would recommend removing the minified files from the commit, as they're likely to prevent clean auto-merging.

[hnrch02]

Done.

[zlatanvasovic]

Is this really needed? .focus() is cleaner syntax than .trigger('focus').

[hnrch02]

Well, it is not needed if you use a jQuery build which excludes nothing.
Given that in all of Bootstrap's JavaScript the .on(eventName, handler) syntax is used instead of the aliases it makes sense to also trigger those events via the direct syntax and not the alias. Also,
if you take a look at the source of $.fn.focus you can see that by calling the alias you're essentially wasting a function call.

[zlatanvasovic]

Yes, but performances are very similar in both cases.

2014-02-17 19:20 GMT+01:00 Heinrich Fenkart [email protected]:

Well, it is not needed if you use a jQuery build which excludes nothing.
Given that in all of Bootstrap's JavaScript the .on(eventName, handler)syntax is used instead of the aliases it makes sense to also trigger those
events via the direct syntax and not the alias. Also,
If you take a look at the sourcehttp://james.padolsey.com/jquery/#v=git&fn=focusof
$.fn.focus you can see that by calling the alias you're essentially
wasting a function call.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12761#issuecomment-35309527
.

Zlatan Vasović - ZDroid

[hnrch02]

I know it is ridiculous to talk about performance on such a scale but still, the difference exists albeit it being relatively small. That is also why it was my second point and I tried to put more emphasis on the consistency argument.

[zlatanvasovic]

OK so far.

2014-02-17 20:15 GMT+01:00 Heinrich Fenkart [email protected]:

I know it is ridiculous to talk about performance on such a scale but
still, the difference exists albeit it being relatively small. That is also
why it was my second point and I tried to put more emphasis on the
consistency argument.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12761#issuecomment-35313866
.

Zlatan Vasović - ZDroid

[hnrch02]

Any news on this? It's not that big of a change and would really help me out.

[mdo]

Sounds legit enough.

[hnrch02]

❤️

[zlatanvasovic]

This kinda breaks semver.

2014-02-22 10:59 GMT+01:00 Heinrich Fenkart [email protected]:

[image: ❤️]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12761#issuecomment-35799133
.

Zlatan Vasović - ZDroid

[hnrch02]

Care to elaborate in which way it should?

[zlatanvasovic]

This removes .focus() to it breaks backwards-compatibility.

2014-02-22 14:18 GMT+01:00 Heinrich Fenkart [email protected]:

Care to elaborate in which way it should?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12761#issuecomment-35802286
.

Zlatan Vasović - ZDroid

[hnrch02]

No, it does not. When no parameter is passed to $.fn.focus, it is just a shortcut for $.fn.trigger('focus'), when the parameter is a function, it's a shortcut for $.fn.on('focus', parameter). See also jquery/src/event/alias.js

[zlatanvasovic]

😕

[mdo]

So, not a problem then?

[zlatanvasovic]

I don't know, I just know that this removes .focus() alias, so that changes
API and usage.

2014-02-22 22:37 GMT+01:00 Mark Otto [email protected]:

So, not a problem then?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/12761#issuecomment-35815567
.

Zlatan Vasović - ZDroid

[mdo]

Maybe @cvrebert can weigh in—I'd like more opinions on this.

[hnrch02]

There is no API change and no usage change, we just use a different method of the jQuery API that does exactly the same thing. I don't know how to convince you further, maybe someone else wanna give it a go?

/cc @cvrebert @fat

[zlatanvasovic]

OK then. You can leave it if you'd want. :)

[cvrebert]

It's A-OK AFAIK.