-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.transition-timing-function() Mixin #12924
Conversation
added .transition-timing-function(@timing-function) mixin, defaults to @timing-function.
I think the plan is to deprecate a lot of those mixins with the switch to autoprefixer (#12670), so I'm not sure if adding a new one to the mix makes sense at this time. |
@BBosman I'm all for killing vendor prefixes ... and thus these mixins. That said, for folks using bootstrap LESS files directly, we may not necessarily run through an autoprefixer task (although, I probably should) so relying on a grunt task in the main build of Bootstrap may not satisfy the need for people who are using the sources directly and generating our own CSS. I will keep this PR open for the choice of the community whether this is useful or not, but I will also go back to my project and use an auto-prefixer as well as CSScomb because that is certainly the right way to do it. |
+1 |
Yeah I'm torn here. Clearly the route we want to go for maintaining Bootstrap is to abandon use of the mixins. However, we still need to include them for folks who just use Less or Sass. I guess our docs should just make that clearer when we implement autoprefixer? |
@mdo I believe the community will support the move, so long as it is clearly documented (the why and the how) of relying on autoprefixer. again, will leave this PR open for the maintainers to decide... |
…-mixin .transition-timing-function() Mixin
Makes sense. But is there a specific reason to call the mixin transition-timing-function instead of animation-timing-function? To me, it would me more logical to have the name match the properties it sets. |
@BBosman you sir, are correct, the mistake is the CSS property it's setting should be |
added
.transition-timing-function(@timing-function)
mixin, defaults to@timing-function
.useful for customizing CSS transitions.
reference: transition-timing-function on MDN