Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use quotes around all element attribute values in JS #12948

Merged
merged 1 commit into from
Mar 6, 2014

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Mar 6, 2014

Fixes #12946. Also more consistent with our CSS code style.

@cvrebert cvrebert added the js label Mar 6, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone Mar 6, 2014
@mdo
Copy link
Member

mdo commented Mar 6, 2014

Legit.

cvrebert added a commit that referenced this pull request Mar 6, 2014
use quotes around all element attribute values in JS
@cvrebert cvrebert merged commit 839f8fa into master Mar 6, 2014
@cvrebert cvrebert deleted the js-quote-attr-vals branch March 6, 2014 22:26
@mdo mdo mentioned this pull request Mar 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown menu won't activate with jquery-xmlns
2 participants