Generate Translations list from YAML #13095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I definitely like this approach! I will check this out closer later and let you know if I have any comments :) |
|
@juthilo: what do you think about this order? - language: German
code: de
description: Bootstrap auf Deutsch
url: http://holdirbootstrap.de/This way it should be also more clear that the language order is based on the language name. |
| <li><a href="http://www.oneskyapp.com/docs/bootstrap/ru">Bootstrap по-русски (Russian)</a></li> | ||
| <li><a href="http://www.oneskyapp.com/docs/bootstrap/es">Bootstrap en Español (Spanish)</a></li> | ||
| <li><a href="http://twbs.site-konstruktor.com.ua">Bootstrap ua Українською (Ukrainian)</a></li> | ||
| {% for translation in site.data.translations %} |
There was a problem hiding this comment.
Maybe use language instead of translation as a loop variable?
EDIT: ...but then we'll have language.language which doesn't look good :/ Maybe language as a variable and name in the yml file?
There was a problem hiding this comment.
Sounds good to me. Pushing up in a minute.
|
Implemented the changes proposed by @XhmikosR. |
|
LGTM 👍 |
mdo
added a commit
that referenced
this pull request
Mar 18, 2014
Generate Translations list from YAML
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds hreflang attribute to the links.
This might help with #13094.
@mdo Now that we split up the docs into includes, the difference in terms of contribution difficulty is not as high as before, I think.
/cc @cvrebert @XhmikosR