Scrollspy generates wrong offsets for a page-- recalculate offsets if scrollheight changes.
#13220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fat
added a commit
that referenced
this pull request
Jun 11, 2014
… offsets if `scrollheight` changes
|
closing in favor of open pr |
|
thanks for filing! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a long landing page that has a lot of images, and occasionally the images load after scrollspy's offset has been generated. The result is that the offset array generated is wrong and it will highlight the wrong images.
Looking at the code in
scrollspy.js, there is no detection for a change in document height.So here's the fix!