-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix carousel-control margin asymmetry #13242
Conversation
Please provide a demonstration of the problem and your fix. Would be much appreciated 😁 |
@hnrch02 at first I attached screenshots, but then my team kicked me for using production data 👍 So here they are, v. 2. |
@hnrch02 probably, some extra-testing is needed, to be honest I don't know how to test it well |
@hnrch02 exactly. Also, I don't understand why there's still 2-pixels (51 vs 49) width difference between both areas? |
@hnrch02 now it's clear to me, thx. And what about PR? |
There's nothing I can do about the PR, I'm just some guy participating in the discussion. Need @mdo on this. |
@hnrch02 do we also need to change |
Fix carousel-control margin asymmetry
Thx for the fix @killthekitten, just stumbled upon this in my carousel as well. |
@elkangaroo 👍 you're welcome |
…controls Fix carousel-control margin asymmetry
While using carousel default controls with a non-default background, I've noticed annoying asymmetry of arrows. Looks like somebody forgot to specify different margins for left and right arrows.