Wait for the expected target during a collapse #13330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually wait for the collapsed item to complete. If complete is called with other target, instead of simply returning and do nothing, wait again until the proper target triggers the event (otherwise this leaves collapse in a broken state).
|
It'd be great if you could add a unit test to exercise this. |
|
I have never added unit tests for JavaScript and I wouldn't know how to at the moment. It happened, the problem, when the div being collapsed has an input inside, with a focus... that's when it happened to me |
|
Still it's pretty obvious, the .one(...) just returns doing nothing, and never again receives the event as it returns without scheduling a "try waiting again"... so the collapsible div remains forever in "collapsing" state... |
|
yep this is fine, (also hard to add a unit test because of transition) lgtm – should merge |
|
@Kronuz thanks for doing this 👍 |
cvrebert
added a commit
that referenced
this pull request
Apr 16, 2014
Wait for the expected target during a collapse
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually wait for the collapsed item to complete. If complete is called
with other target, instead of simply returning and do nothing, wait again
until the proper target triggers the event (otherwise this leaves collapse
in a broken state).