Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown menu in justified button-group #13369

Merged
merged 1 commit into from
May 13, 2014
Merged

Conversation

armikbd
Copy link
Contributor

@armikbd armikbd commented Apr 17, 2014

This is a firefox issue. I tested it on firefox latest (28.0).

It seems that dropdown-menu in justified button-group appears at the far left of the group.

Check the problem in Bootstrap site.

ff28-btn-group

It seems that dropdown-menu in justified button-group appears at the far
left of the group. Check the problem in [Bootstrap
site](http://getbootstrap.com/components/#btn-groups-justified).
@cvrebert cvrebert added the css label Apr 17, 2014
@cvrebert
Copy link
Collaborator

Confirmed.

@cvrebert
Copy link
Collaborator

Seems to be due to the left: 0; on .dropdown-menu?
[Edit: I missed that this was a pull request...]

@Jakobovski
Copy link

@cvrebert I just checked in Firefox 28.0 and the issue is definitely due to the left: 0: on .dropdown-menu.

The parent element's class .btn-group has the property display: table-cell;. Firefox ignores relative positioning if assigned to any table cell element. Relative positioning of a table cell element is undefined by the W3C, so Firefox isn’t breaking the rules.

What would be the consequences of removing the left:0; from .dropdown-menu?

@cvrebert cvrebert added this to the v3.2.0 milestone Apr 18, 2014
@cvrebert
Copy link
Collaborator

Duplicate of #12467.

mdo added a commit that referenced this pull request May 13, 2014
Dropdown menu in justified button-group
@mdo mdo merged commit 5938774 into twbs:master May 13, 2014
@mdo mdo mentioned this pull request May 13, 2014
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Dropdown menu in justified button-group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants