-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about IE emulation modes in docs+examples #13422
Conversation
I personally find it very useful to try things locally without much hassle. But I agree, people shouldn't use it especially with IE11 not respecting conditionals anymore. I'll try the patch in action later and let you know. |
I tested every actualIE-emulatedIE combo for IE 8-11 via Sauce and it worked, so it should be fine technically speaking. |
BTW, I wouldn't remove semicolons... Sure it's not consistent with the current style, but there's no real progress on that, so I'd say use what you prefer in that regard. |
Hmm, do we need to have this in our code or can we not just be more specific in our bug report docs? I know there will inevitably be overhead, but this only addresses the docs and our examples. Any js bin reports or other demos will still face similar problems. |
Very few people read the bug report docs.
Are you okay with the phrasing of the warning message? |
Warn about IE emulation modes in docs+examples
We can always further tweak the message later. |
This script, which I've pretty exhaustively tested manually using Sauce, alerts the user about the perils of trying to use IE's emulation modes to test older versions of IE.
These emulation modes can behave differently from actual IE, which can lead users to file Bootstrap bugs about supposed IE8 problems which don't occur when tested properly using actual IE8.
Examples of emulation inaccuracy:
This should hopefully reduce the amount of time wasted chasing down false IE8 bug reports.
/cc @twbs/team for review