Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about IE emulation modes in docs+examples #13422

Merged
merged 4 commits into from
Apr 28, 2014

Conversation

cvrebert
Copy link
Collaborator

This script, which I've pretty exhaustively tested manually using Sauce, alerts the user about the perils of trying to use IE's emulation modes to test older versions of IE.
These emulation modes can behave differently from actual IE, which can lead users to file Bootstrap bugs about supposed IE8 problems which don't occur when tested properly using actual IE8.

Examples of emulation inaccuracy:

This should hopefully reduce the amount of time wasted chasing down false IE8 bug reports.
/cc @twbs/team for review

@cvrebert cvrebert added this to the v3.2.0 milestone Apr 24, 2014
@XhmikosR
Copy link
Member

I personally find it very useful to try things locally without much hassle. But I agree, people shouldn't use it especially with IE11 not respecting conditionals anymore.

I'll try the patch in action later and let you know.

@cvrebert
Copy link
Collaborator Author

I tested every actualIE-emulatedIE combo for IE 8-11 via Sauce and it worked, so it should be fine technically speaking.
@mdo Does the concept+wording seem good to you?

@XhmikosR
Copy link
Member

BTW, I wouldn't remove semicolons... Sure it's not consistent with the current style, but there's no real progress on that, so I'd say use what you prefer in that regard.

@mdo
Copy link
Member

mdo commented Apr 25, 2014

Hmm, do we need to have this in our code or can we not just be more specific in our bug report docs? I know there will inevitably be overhead, but this only addresses the docs and our examples. Any js bin reports or other demos will still face similar problems.

@cvrebert
Copy link
Collaborator Author

can we not just be more specific in our bug report docs?

Very few people read the bug report docs.

this only addresses the docs and our examples. Any js bin reports or other demos will still face similar problems.

  • A significant portion of the relevant issues are about our docs or examples supposedly not working.
  • Lots of folks probably (in the same browser) at least consult or in some cases crosscheck against our docs before they get to the point of deciding that they need to file an issue. This new warning will also cover those cases.
  • Every little bit helps when you get as many issues as we do. 😄

Are you okay with the phrasing of the warning message?

cvrebert added a commit that referenced this pull request Apr 28, 2014
Warn about IE emulation modes in docs+examples
@cvrebert cvrebert merged commit bde5f1f into master Apr 28, 2014
@cvrebert
Copy link
Collaborator Author

We can always further tweak the message later.

@cvrebert cvrebert deleted the ie-emulation-modes-warning branch April 28, 2014 05:29
@mdo mdo mentioned this pull request Apr 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants