-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variables for media queries #13502
Variables for media queries #13502
Conversation
Why? |
I've found #13014 is for the same purpose. Seems like this implementation is almost the same, except it'll takes less space in sass. |
Indeed i took the idea and some code from foundation, then adopted it for bootstrap :/. It also had |
Maybe it'll be better to remove this rule to be able to use this rules for other medias. And markup will remain responsive for all medias. I'll remove it right now. |
Also, |
I suspect that we'll end up preferring #13014, since it doesn't involve using raw string interpolation. |
I updated all media queries in project. What do you think about |
Sorry, missed. So should i close PR in favor of #13014? |
I think this method is more readable and follows less surprise principle. |
@mdo will decide between this PR and the other PR. |
|
Punting on this one. |
This allows use media queries like this:
It also adds
screen
for all current media queries. I can remove it, if you think it's not necessary.