Allow for resetText of a button to be a falsey value; fixes #13466 #13511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to comply with |
|
Should I include a unit test for this? |
|
It would certainly be nice if you did. |
|
Just went ahead and copy-pasted the previous test, let me know if I should do it differently, I'm not that experienced with QUnit. |
|
lgtm, thanks! |
cvrebert
added a commit
that referenced
this pull request
May 6, 2014
Allow for resetText of a button to be a falsey value; fixes #13466
Closed
|
@hnrch02: this breaks tests with strict comparisons https://travis-ci.org/twbs/bootstrap/jobs/24849122 |
|
Hmm, everything passes locally. If you change the style to comply with eqeqeq, you'll need to compare it to |
|
Thanks. I changed both checks to check for undefined since that's what its value was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @fat @cvrebert