Fixed affix-bottom positioning #13541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set top position to (scrollHeight - this.$element.height() - offsetBottom).
|
Actually, I just examined the history and the bug has been introduced by f7c360d with comment "Simplified calculation of the top offset when in the bottom state". By trying to simplify things, this commit introduces the bug I'm facing: fail to correctly position the affixed element when a page is refreshed while already being scrolled to bottom. |
|
ah ok, looks good to me |
|
thanks |
Closed
|
X-Ref: #12862 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When playing with an affixed sidebar, I noticed the sidebar could overlap my footer depending on the speed at which I scroll the page.
I also noticed that when I open Chrome dev tools and I make the dev tools panel take most of the height of the page, then refreshing the page would style my sidebar with
.affix-bottomstraight and also make it overlap my footer.This is caused by
this.$element.offset({ top: position.top })which positions the affixed element depending on its current position which only works if you transition smoothly from.affixto.affix-bottom.I suggest this line gets replaced with
this.$element.offset({ top: scrollHeight - this.$element.height() - offsetBottom })which corresponds to the computation made to decide whether or not to switch to.affix-bottomstate.I'm a first time Bootstrap user so please forgive me if I overlooked something obvious.
What do you think?