Add tooltip self-reference to address #12320 #13593
Conversation
|
@ResentedHook: you should just skip the revert commit alltogether or include it in the same patch. |
|
We should also add this to the tooltip+popover docs. |
|
I can't include the CSS in the patch since the changes aren't mine (I don't understand how my grunt task would build this CSS package differently than the previous commiter).
|
|
Don't bother. I'm fine with fixing up the commits before merging them. Just need @fat to give his final okay on this. |
|
You should rebase then and skip that commit. The reason this happens is because a change got in probably accidentally and no one has pushed a |
primarily adds a data- attribute to the tooltip (and thus, the popover) to create a self-reference.
| @@ -166,6 +166,7 @@ | |||
| .detach() | |||
| .css({ top: 0, left: 0, display: 'block' }) | |||
| .addClass(placement) | |||
| .data('bs.' + this.type, this) | |||
There was a problem hiding this comment.
Similar to the modal.js call to $this.data('bs.modal', ...), the tooltip has to accommodate the type - tooltip, popover, etc.
|
The rebase looks good now @ResentedHook :) |
|
|
lg |
maybe lets be quiet about it for a while… and if it comes up a few times, we can add to docs? |
|
Running Sauce test: https://travis-ci.org/twbs/bootstrap/jobs/25907822 |
|
Sauce tests passed. Merging per @fat's LG. |
Add tooltip self-reference to address #12320
|
hooray! |
|
Even in 3.2.0 it sometimes happens that $(event.target).data('bs.popover').$tip is undefined in a show.bs.popover handler (id does NOT happen in shown.bs.popover). I am investigating the issue. |
refer to #12342; recovering from botched rebase...forked fresh and manually merged changes.
Tests passing.