Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show proper error message when viewing Customizer in IE8 #13626

Merged
merged 1 commit into from
May 23, 2014

Conversation

cvrebert
Copy link
Collaborator

Closes #13090.
Modulo the <strong> tag I've since added, here's what this looks like:
ie8
Note that this only shows in IE<9.

@mdo Sound acceptable?

@cvrebert cvrebert added this to the v3.2.0 milestone May 19, 2014
@mdo
Copy link
Member

mdo commented May 21, 2014

Can we not use a huge alert and instead keep it a sane, default size, and then add some IE-specific styles to simply hide the container and sidebar? Something like:

<!--[if lt IE 9]>
<style>
  .bs-docs-section,
  .bs-docs-nav {
    display: none;
  }
</style>
<![endif]-->

@cvrebert
Copy link
Collaborator Author

Yeah, that could work.

@cvrebert
Copy link
Collaborator Author

@mdo Okay, done.

@mdo
Copy link
Member

mdo commented May 23, 2014

Fantabulous. Merge at your discretion <3.

cvrebert added a commit that referenced this pull request May 23, 2014
show proper error message when viewing Customizer in IE8
@cvrebert cvrebert merged commit 676fda9 into master May 23, 2014
@cvrebert cvrebert deleted the address-13090 branch May 23, 2014 15:48
@mdo mdo mentioned this pull request May 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm that the customizer blocks IE<=9, or fix it so that it does.
3 participants