Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repaint Fixes When Scrolling #13649

Merged
merged 1 commit into from
Jun 8, 2014
Merged

Repaint Fixes When Scrolling #13649

merged 1 commit into from
Jun 8, 2014

Conversation

ItsJonQ
Copy link
Contributor

@ItsJonQ ItsJonQ commented May 21, 2014

Heya guys!

Here's my 2nd attempt at this. Thanks again for being so patient with my first try.

Ideally, translateZ(0) would work the best in the spots that I've added the vendor-prefix mixin of .translate3d() as it has IE9 support. Based on feedback from my first PR, I avoided adding a mixin specifically for translateZ.

The translate3d fix for .modal is tricky. It effectively fixes repaints on scroll.. but it might be problematic for IE 8-9.

Thanks!

@cvrebert cvrebert added the css label May 21, 2014
@cvrebert cvrebert added this to the v3.2.0 milestone May 21, 2014
@cvrebert cvrebert mentioned this pull request May 21, 2014
@mdo
Copy link
Member

mdo commented May 21, 2014

The translate3d fix for .modal is tricky. It effectively fixes repaints on scroll.. but it might be problematic for IE 8-9.

I can check that out—I've got a couple VMs locally to peep this in before merging.

@mdo
Copy link
Member

mdo commented May 21, 2014

Thanks again for being so patient with my first try.

And no, thank you for not giving up <3.

@ItsJonQ
Copy link
Contributor Author

ItsJonQ commented May 21, 2014

@mdo Dawww, thanks dude :). You're the best (around. Nothing's ever gonna keep you down..) Hopefully everything checks out!

mdo added a commit that referenced this pull request Jun 8, 2014
@mdo mdo merged commit 3ee5542 into twbs:master Jun 8, 2014
@mdo mdo mentioned this pull request Jun 8, 2014
@mdo
Copy link
Member

mdo commented Jun 8, 2014

Thanks!

@cvrebert
Copy link
Collaborator

cvrebert commented Oct 3, 2014

So, for folks keeping score at home, these changes ended up being reverted due to Safari bugs, bad-looking fonts on Windows, and navbar customization problems.
Isn't the Web great? 😬

@ItsJonQ
Copy link
Contributor Author

ItsJonQ commented Oct 3, 2014

@cvrebert No problem! Sorry for all the trouble this guy caused :(.

@jmcbee
Copy link

jmcbee commented Oct 8, 2014

hi @ItsJonQ can you show the before and after timeline of this? Would be awesome! Too bad it conflicts with other stuffs.

@ItsJonQ
Copy link
Contributor Author

ItsJonQ commented Oct 8, 2014

Heya @fbm-static ,

Sure! I'd be more than happy to do that.. but I'm not sure where to find that info (sorry!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants