Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Updates to Scrollspy.js #13702

Closed
wants to merge 4 commits into from

Conversation

mikegreiling
Copy link
Contributor

Minor refactoring...

  • Make this.offsets and this.targets vanilla javascript arrays again
  • Removes check for href attribute on the scrollable element – No one is going to use an <a> tag to define a scrollable block
  • Removes this.$element since it was merely a duplicate of this.$scrollElement
  • Combine logic of multiple segments within the refresh method which depend on whether or not $scrollElement is equal to window for better speed and readability.

@cvrebert
Copy link
Collaborator

Please fix the violations of our coding style rules; see the Travis build failure for details.

@cvrebert cvrebert added this to the v3.2.1 milestone May 29, 2014
@cvrebert cvrebert added the js label May 29, 2014
@mikegreiling
Copy link
Contributor Author

Should be fixed now... how do I rerun the Travis build?

Edit: Nevermind, seems to be going now...

@fat
Copy link
Member

fat commented Jun 7, 2014

code, lgtm

@cvrebert
Copy link
Collaborator

cvrebert commented Jun 8, 2014

Sauce tests passed: https://travis-ci.org/twbs/bootstrap/builds/27043510

@cvrebert cvrebert modified the milestones: v3.2.0, v3.2.1 Jun 8, 2014
@cvrebert cvrebert closed this in 1cfa902 Jun 8, 2014
@mdo mdo mentioned this pull request Jun 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants