Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unnecessary max-width on tables #13707

Merged
merged 1 commit into from
Jun 8, 2014
Merged

removing unnecessary max-width on tables #13707

merged 1 commit into from
Jun 8, 2014

Conversation

bcullman
Copy link
Contributor

From the history, it appears max-width was added to tables.less when various css declarations originating in reset.less were relocated to appropriate less files so that reset.less could be removed in favor of normalize.less.

However, this max-width declaration did not come from Eric Meyer's reset.less. Instead, it was added in the following check-in by @mdo "help tables not look like shit on mobile maybe?"

97b2858

I don't believe that this declaration has proven it helps layouts on mobile. However it does cause layout problems when using bootstrap in conjunction with other javascript libraries.

If the original implementation was iffy to begin with, lets just remove it.

@cvrebert cvrebert added the css label May 29, 2014
@cvrebert cvrebert added this to the v3.2.1 milestone May 29, 2014
@cvrebert
Copy link
Collaborator

However it does cause layout problems when using bootstrap in conjunction with other javascript libraries.

Do you have an example of this?

@bcullman
Copy link
Contributor Author

I am using bootstrap in a legacy app that also uses an old version of extJS for some parts of the UI.

extJS builds nearly all of their widgets with non-semantic HTML (aka tables). When doing re-size calculations, table elements are returning the value "1" for width value rather than the correct width in pixels, and this is due to the max-width statement on table in bootstrap.

I won't argue that this is due to a bug in the old extJS implementation - it likely is.

However when reviewing the Bootstrap history, it looks like this max-width statement was erroneously added.

@cvrebert
Copy link
Collaborator

It's also weird that we are applying this CSS to all <table> elements rather than just to the .table class.

@mdo mdo modified the milestones: v3.2.1, v3.2.0 Jun 8, 2014
mdo added a commit that referenced this pull request Jun 8, 2014
@mdo mdo merged commit aee18bc into twbs:master Jun 8, 2014
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
…ble-max-width

removing unnecessary max-width on tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants