removing unnecessary max-width on tables #13707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the history, it appears max-width was added to tables.less when various css declarations originating in reset.less were relocated to appropriate less files so that reset.less could be removed in favor of normalize.less.
However, this max-width declaration did not come from Eric Meyer's reset.less. Instead, it was added in the following check-in by @mdo "help tables not look like shit on mobile maybe?"
97b2858
I don't believe that this declaration has proven it helps layouts on mobile. However it does cause layout problems when using bootstrap in conjunction with other javascript libraries.
If the original implementation was iffy to begin with, lets just remove it.