fix #13185 - keyboard support for carousel #13787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ | |||
| // ========================= | |||
|
|
|||
| var Carousel = function (element, options) { | |||
| this.$element = $(element) | |||
| this.$element = $(element).on('keydown', $.proxy(this.keydown, this)) | |||
There was a problem hiding this comment.
We should probably namespace this, though the mouseenter and mouseleave events aren't either so I'm not so sure...
|
lg? |
| } | ||
|
|
||
| e.preventDefault() | ||
| } |
There was a problem hiding this comment.
This seems more fitting 😄
Carousel.prototype.keydown = function (e) {
if (!/37|39/.test(e.which)) return
this[e.which == 37 ? 'prev' : 'next']()
e.preventDefault()
}Also, ref
There was a problem hiding this comment.
yeah it was a switch statement because mark and i were going back and forth with adding a first/last option
There was a problem hiding this comment.
also think the switch is a bit more elegant in this case - only one condition, etc
There was a problem hiding this comment.
Yeah, but the semicolons aren't that elegant.
|
Looking good to whom? You might wanna cc someone specific in. |
(Even though the semicolon situation in the switch could be improved.)
fat
added a commit
that referenced
this pull request
Jun 11, 2014
fix #13185 - keyboard support for carousel
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.