Major unit tests cleanup #13853
Merged
Major unit tests cleanup #13853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setTimeout(function () { | ||
| window.scroll(0, 0) | ||
| }, 0) | ||
| }, 18) // for testing in a browser |
There was a problem hiding this comment.
ha could you leave a bit more in this note… why 18?
There was a problem hiding this comment.
It didn't work with 0, obviously, so I moved to a higher number and remembered that Paul Irish's rAF polyfill used 18 (it actually uses 16 ms, now that I see it. I guess I remembered wrongly).
|
this is super rad. thanks so much for doing this… left a few tiny notes |
|
Will work on the rest later, gonna eat some now. |
|
heh ok |
| var template = $('<div id="affixTarget"><ul><li>Please affix</li><li>And unaffix</li></ul></div><div id="affixAfter" style="height: 20000px; display:block;"></div>') | ||
| template.appendTo('body') | ||
| var templateHTML = '<div id="affixTarget">' | ||
| + '<ul>' |
There was a problem hiding this comment.
These all have four spaces, the original templates that were spread across lines were all indented by four spaces, so I sticked to it. Should I move to two?
|
major ❤️ for this, thanks again |
Closed
|
✨ |
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty big PR attempting to clean up our unit tests. I reworked a few, but mostly performed style/consistency updates.
I created separate commits for the cleanup of each file, I don't know but that may help during the review. Will ofc squash if it is decided that this should be merged.
Also, I'll need to spend some time on the scrollspy tests, my shallow inspection concluded that they might not work as intended.The scrollspy test will work once #13500 is merged./cc @fat @cvrebert @XhmikosR