Add .form-group-sm/-lg #13856
Closed
Add .form-group-sm/-lg #13856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflicts were dumb, so I reset to 74a264f and merged it right into master locally. |
Closed
martin-g
added a commit
to martin-g/wicket-bootstrap
that referenced
this pull request
Jun 27, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13021.
This is a bit janky because forms and what not, but it gets the job done. The exact technique for large groups vs small groups varies due to the sizing methods of our inputs. For that reason alone, I kind of question this addition. It feels like I'm patching something otherwise faulty, but I don't have a better idea yet.