assign background to row of .table-striped #13920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if background is not set on row, striping doesn't work properly in responsive tables where row and cells are set to display: block.
| @@ -106,6 +106,7 @@ th { | |||
|
|
|||
| .table-striped { | |||
| > tbody > tr:nth-child(odd) { | |||
| background-color: @table-bg-accent; | |||
| > td, | |||
| > th { | |||
| background-color: @table-bg-accent; | |||
There was a problem hiding this comment.
Doesn't that make this rule redundant?
There was a problem hiding this comment.
I guess td and th backgrounds can be removed
not sure why the original decision was to style the cells, not the rows
in fact the rows aren't styled anywhere.
|
update committed @cvrebert |
|
Ah, I see it. In Safari, I see the striping but only for the cells that are currently in view. Anything overflowed that needs scrolling to see is fubared. |
|
do you guys want me to add more to this or what's the process from here? |
|
I just need to review more. Hoping to get into v3.2.1 (and release that in early to mid August). |
mdo
added a commit
that referenced
this pull request
Jul 6, 2014
assign background to row of .table-striped
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
assign background to row of .table-striped
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if background is not set on row, striping doesn't work properly in responsive tables where row and cells are set to display: block.
sorry, no bug report - jumped straight to fixing
bin
http://jsbin.com/cuyov/1/edit?html,css,output