Added @gray-base variable to make @gray-{shade} reference, also allows @... #13923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s @gray-base to be modified with less#modifyVars and the vars to cascade
| @gray: lighten(#000, 33.5%); // #555 | ||
| @gray-light: lighten(#000, 46.7%); // #777 | ||
| @gray-lighter: lighten(#000, 93.5%); // #eee | ||
| @gray-base: #000; |
There was a problem hiding this comment.
Horizontal alignment is off by 1 char
There was a problem hiding this comment.
Whats the easiest way to submit amendments to a PR?
There was a problem hiding this comment.
Make another commit on your gray-base-variable branch and push the updated branch to GitHub. Although for very minor stuff like this, we often just fix it ourselves when merging the pull request.
mdo
added a commit
that referenced
this pull request
Jul 6, 2014
Added @gray-base variable to make @Gray-{shade} reference, also allows @...
Closed
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
…iable Added @gray-base variable to make @Gray-{shade} reference, also allows @...
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows @gray-base to be modified with less#modifyVars (see Using Less in the Browser) and the vars to cascade.
The reason I did this is that as I mentioned it allows less to cascade the changes to the @gray variables if the @gray-base variable is changed.
It also makes sense as all the variables have the same value, so why not extract it into a single variable.
I have done something similar in my own variables_custom.less file for my BootstrapThemeEditor project.