Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "pointer" cursor on disabled list-group-item #13931

Merged
merged 2 commits into from
Jun 26, 2014
Merged

Conversation

ByScripts
Copy link
Contributor

This update remove the "pointer" cursor when a "disabled" class is added to a linked list-group-item

@cvrebert
Copy link
Collaborator

If we're to be consistent with our other disabled styles, this should probably use not-allowed rather than default.

@cvrebert cvrebert added this to the v3.2.1 milestone Jun 26, 2014
@cvrebert cvrebert added the css label Jun 26, 2014
@ByScripts
Copy link
Contributor Author

You are totally right. I made the correction.

Thank you.

@ByScripts
Copy link
Contributor Author

Well, this cause another issue.

Maybe we should set the cursor to not-allowed only on a.list-group-item rather than .list-group-item ?

Or should a "non-link" element have the not-allowed cursor when disabled ?

@mdo
Copy link
Member

mdo commented Jun 26, 2014

I think it's fine just on the disabled state, doesn't need to be scoped to links.

mdo added a commit that referenced this pull request Jun 26, 2014
Remove "pointer" cursor on disabled list-group-item
@mdo mdo merged commit 2b6f00c into twbs:master Jun 26, 2014
@mdo
Copy link
Member

mdo commented Jun 26, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants