Docs clean up - unnecessary role attributes, callout clarifications #15125
Conversation
|
(Fixed Markdown formatting in your description by adding backticks around |
|
btw my esteemed colleague and ARIA guru @stevefaulkner confirms that those |
|
@patrickhlauke: don't forget a rebase and squash when you are ready. |
plus one example that still used the old <div role="navigation"> and a fix-up of the callout as per #15109
|
You forcing me to learn git yet again, eh? Done. To avoid my usual "mega-PR" syndrome, i'll leave this at that... |
|
Looks much better now, thanks! PS. I'm against one commit PRs too. I just like having clean, separate patches. |
|
Where are we on this guys? |
|
good from my end. i've double-checked with a few more colleagues in the accessibility community, and the overall consensus is that those roles are redundant |
|
Cool, then. @cvrebert: push the button! |
Docs clean up - unnecessary role attributes, callout clarifications
The removal of
role="form"may be considered contentious. It seems that, compared to the clear-cut case of<nav>not needingrole="navigation",<form>does not explicitly get a role of form (at least, it doesn't seem to be exposed in my quick testing). So, havingrole="form"can be useful, but only in cases where the author wants to make a form an explicit important landmark. For this reason (requires explicit author intent), I'd leave the attribute out from the general examples here.Fixes #15109.