honor wrap option in Carousel.getItemForDirection #15152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var activeIndex = this.getItemIndex(active) | ||
| var willWrap = (direction == 'prev' && activeIndex === 0) |
There was a problem hiding this comment.
Any reason for the strict comparison here?
There was a problem hiding this comment.
The JSCS check complains otherwise.
There was a problem hiding this comment.
I guess because of false == 0. Never mind then.
|
Otherwise LGTM. +:100: for the unit tests. |
|
@XhmikosR LGTY? |
|
Sorry, I missed the notification :/ Is the JSFiddle example right? I can't see next at all, only the previous link. |
|
Yeah, the example from the other issue that I based the demo on is a bit off. Here's one with fixed next/prev icons: http://jsfiddle.net/9qxsyf27/4/ |
|
That code is something I'm not very familiar with, but I think they look good, as far as I can tell. And unit tests are a huge plus. |
cvrebert
added a commit
that referenced
this pull request
Nov 17, 2014
honor wrap option in Carousel.getItemForDirection [skip validator]
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15144. Demo: http://jsfiddle.net/9qxsyf27/1/
Also adds unit test for Carousel's
wrapoption to avoid such regressions in the future.CC: @KostyaTretyak @hnrch02 @XhmikosR @fat