Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested button groups with only one child now have rounded corners #15278

Merged
merged 1 commit into from
Jan 18, 2015
Merged

Nested button groups with only one child now have rounded corners #15278

merged 1 commit into from
Jan 18, 2015

Conversation

m-smith
Copy link
Contributor

@m-smith m-smith commented Dec 3, 2014

Fixes #15270. I just added the appropriate :not() selectors to prevent the styles from being applied when the first-child is also the last-child.

@cvrebert cvrebert added the css label Dec 3, 2014
@JaredCowan
Copy link

@m-smith Sorry if I'm wrong. But shouldn't it be :not(only-child)

@cvrebert cvrebert added this to the v3.3.3 milestone Jan 8, 2015
@mdo mdo modified the milestones: v3.3.2, v3.3.3 Jan 18, 2015
@juthilo juthilo mentioned this pull request Jan 18, 2015
Closed
@mdo
Copy link
Member

mdo commented Jan 18, 2015

Put this through the paces in https://jsbin.com/sunowo/1/ and things look good.

@mdo mdo merged commit dbe4765 into twbs:master Jan 18, 2015
@m-smith m-smith deleted the btn-group-rounding branch January 18, 2015 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.

Nested .btn-group not rounded if only child
4 participants
@m-smith @JaredCowan @mdo @cvrebert