Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and properly report compile errors that Less.js's toCSS() can throw #15309

Merged
merged 1 commit into from
Dec 5, 2014

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Dec 5, 2014

Currently these errors are only reported in the JavaScript console, not in the Customizer UI.
Refs #15296.

…oCSS() can throw.

Currently these errors are only reported in the JavaScript console, not in the Customizer UI.
Refs #15296

[skip sauce]
[skip validator]
@cvrebert cvrebert added this to the v3.3.2 milestone Dec 5, 2014
cvrebert added a commit that referenced this pull request Dec 5, 2014
Catch and properly report compile errors that Less.js's toCSS() can throw
@cvrebert cvrebert merged commit f110243 into master Dec 5, 2014
@cvrebert
Copy link
Collaborator Author

cvrebert commented Dec 5, 2014

Happy to tweak this later, but merging now since it's impacting the hosted customizer.

@cvrebert cvrebert deleted the fix-customizer-compile-err-reporting branch December 5, 2014 21:20
cvrebert added a commit that referenced this pull request Dec 5, 2014
@juthilo juthilo mentioned this pull request Dec 6, 2014
@hnrch02
Copy link
Collaborator

hnrch02 commented Dec 16, 2014

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants