Docs accessibility tweaks #15320
Merged
Docs accessibility tweaks #15320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorter, neater, well supported
| @@ -28,31 +28,33 @@ | |||
| {% unless page.fullwidth == true %} | |||
| <div class="col-md-3"> | |||
| <div class="bs-docs-sidebar hidden-print hidden-xs hidden-sm" role="complementary"> | |||
There was a problem hiding this comment.
Why not just change this from a div to a nav?
Harmonizing this with same advice given for CSS inline forms
...and remove the redundant paragraph for basic abbreviation, which simply repeats what was just said above.
|
@cvrebert good catch...tweaked the tweak :) |
|
|
patrickhlauke
added a commit
that referenced
this pull request
Dec 7, 2014
Docs accessibility tweaks: use ``aria-label`` for close ``<button>``, expand advice for ``<abbr>``, form control labels, make sidebar navigation a ``<nav>``
|
@patrickhlauke Could you add a ship list (#15103) entry for this? |
Closed
cvrebert
added a commit
that referenced
this pull request
Dec 16, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.