Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skip link look less "bare bones" #15363

Merged
merged 2 commits into from
Dec 14, 2014
Merged

Make skip link look less "bare bones" #15363

merged 2 commits into from
Dec 14, 2014

Conversation

patrickhlauke
Copy link
Member

Additional markup for the skip link (to ensure it has the same effective width as the main content, and to provide an outline around just the link text) plus some basic styles...make it look a bit more in keeping with the overall look and feel of the docs.

@patrickhlauke
Copy link
Member Author

Additional tweak to the skip link explanation in the accessibility section...

@patrickhlauke
Copy link
Member Author

skippy

@cvrebert cvrebert added this to the v3.3.2 milestone Dec 14, 2014
padding: 1em;
color: #fff;
background-color: #6F5499;
outline: none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 0 over none for zero values.

Additional markup for the skip link (to ensure it has the same effective
width as the main content, and to provide an outline around just the
link text) plus some basic styles...make it look a bit more in keeping
with the overall look and feel of the docs.
@patrickhlauke
Copy link
Member Author

@mdo done :)

@mdo
Copy link
Member

mdo commented Dec 14, 2014

:shipit:

patrickhlauke added a commit that referenced this pull request Dec 14, 2014
@patrickhlauke patrickhlauke merged commit c187f77 into twbs:master Dec 14, 2014
@juthilo juthilo mentioned this pull request Dec 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants