Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table-striped to work with bootstraps tooltips on rows #15551

Merged
merged 1 commit into from
Jan 18, 2015

Conversation

lee101
Copy link
Contributor

@lee101 lee101 commented Jan 13, 2015

Reported in this issue #6420

This fixes having popovers and tooltips on rows in a .table-striped table
The issue was that popovers add a div after the element which was changing the ordering of the striping

@cvrebert
Copy link
Collaborator

This definitely seems nicer than the current "you must use container: 'body' in your tooltip/popover options" solution.

@cvrebert cvrebert added the css label Jan 13, 2015
@cvrebert cvrebert added this to the v3.3.3 milestone Jan 13, 2015
@BBosman
Copy link
Contributor

BBosman commented Jan 13, 2015

I thought IE8 doesn't support nth-of-type?

@cvrebert
Copy link
Collaborator

It doesn't support nth-child either, so this is no worse than the status quo in that respect.

@mdo
Copy link
Member

mdo commented Jan 16, 2015

Yeah, I don't think we can do this until v4 when we drop IE8.

@cvrebert
Copy link
Collaborator

@mdo
Copy link
Member

mdo commented Jan 16, 2015

Doh :D.

@mdo mdo modified the milestones: v3.3.2, v3.3.3 Jan 18, 2015
mdo added a commit that referenced this pull request Jan 18, 2015
Fix table-striped to work with bootstraps tooltips on rows
@mdo mdo merged commit e39b5b5 into twbs:master Jan 18, 2015
@juthilo juthilo mentioned this pull request Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants