Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds button styles to .list-group-item #16215

Merged
merged 3 commits into from
May 14, 2015
Merged

Conversation

zacechola
Copy link

Closes #16204.

Includes buttons with anchor sytles and modifies buttons to match width
and text alignment.

This doesn't yet address the accessibility issue @patrickhlauke raised in that thread, nor does it yet add documentation on the use of buttons.

Includes buttons with anchor sytles and modifies buttons to match width
and text alignment.
@mtscout6
Copy link

mtscout6 commented Apr 2, 2015

Does it really close #16204 if it doesn't account for the accessibility concerns? 😉

@zacechola
Copy link
Author

yet

😄

I'm not sure if it'll make more sense to tack documentation changes onto this PR or to do that as a separate one.

@mdo
Copy link
Member

mdo commented Apr 25, 2015

It'd be cool to update the docs to mention this as well @zacechola. Want to take a stab at duplicating the Linked items section for the button variation?

@patrickhlauke Did you want to add something to the docs about this stuff?

@zacechola
Copy link
Author

No problem. I'll add that.

Zac Echola added 2 commits April 28, 2015 09:45
Mostly a duplication of the *Linked items* section, but for buttons.
Includes a note not to use the standard btn classes.
mdo added a commit that referenced this pull request May 14, 2015
Adds button styles to `.list-group-item`
@mdo mdo merged commit c5babda into twbs:master May 14, 2015
@cvrebert cvrebert mentioned this pull request May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List group with anchors and buttons semantic html and accessibility
4 participants