Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More bower.json fixes #16379

Merged
merged 2 commits into from
Apr 27, 2015
Merged

More bower.json fixes #16379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52d8a0c
bower.json: rm moot `version` field
cvrebert Apr 27, 2015
f1e1411
bower.json: Add `license` field
cvrebert Apr 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"name": "bootstrap",
"description": "The most popular front-end framework for developing responsive, mobile first projects on the web.",
"version": "3.3.4",
"keywords": [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I had in my bower file v3.3.* and the removal of version broke my build using grunt wiredep, for anyone else that might have come across the same issue. It's ok now, I don't need the version in the bower file. I just locked down the specific version and it works. Out of curiosity, may I ask why remove the version in the bower file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byronmansfield As noted in both the commit message and pull request description, see bower/spec@a325da3

"css",
"js",
Expand All @@ -13,6 +12,7 @@
"web"
],
"homepage": "http://getbootstrap.com",
"license": "MIT",
"moduleType": "globals",
"main": [
"less/bootstrap.less",
Expand Down